-
guqing created a review on pull request #31 in halo-sigs/plugin-moments
-
guqing commented on issue #32 in halo-sigs/plugin-moments
-
guqing commented on issue #32 in halo-sigs/plugin-moments
是的,图片需要主题适配,如何显示由主题端自己决定,示例 guqing's blog moments
-
guqing pushed to refs/heads/main in guqing/halo-theme-higan
-
guqing pushed to refs/heads/main in guqing/halo-theme-higan
-
guqing opened pull request #4179 in halo-dev/halo
What type of PR is this?
/kind improvement
/area core
/area plugin
/milestone 2.7.xWhat this PR does / why we need it:
修复生产模式下插件安装时的位置信息为绝对路径会影响迁移的问题
how to test it?
- 生产模式下安装插件看 annotation 中
plugin.halo.run/plugin-path
的值是否为相对于 pluginsRoot 的相对路径 - 在生产模式下在 main 分支启动后安装的插件切换到此 PR 后
plugin.halo.run/plugin-path
是否变为相对路径
Which issue(s) this PR fixes:
Fixes #4178
Does this PR introduce a user-facing change?
修复生产模式下插件安装时的位置信息为绝对路径会影响迁移的问题
- 生产模式下安装插件看 annotation 中
-
guqing created branch refactor/4178 in guqing/halo
guqing/halo
✍ 一款优秀的开源博客发布应用。 -
guqing opened issue #4178 in halo-dev/halo
Your current Halo version
latest
Describe this feature
如下,首次安装时
plugin.halo.run/plugin-path
anotation 的值是一个绝对路径,这会影响迁移{ "spec": { "displayName": "highlight.js 代码高亮" }, "apiVersion": "plugin.halo.run/v1alpha1", "kind": "Plugin", "metadata": { "finalizers": [ "plugin-protection" ], "name": "PluginHighlightJS", "annotations": { "plugin.halo.run/plugin-path": "/Users/guqing/halo2-dev/plugins/PluginHighlightJS-1.1.0.jar" }, "version": 9, "creationTimestamp": "2023-07-04T03:58:42.283900Z" } }
当插件就位于 pluginsRoot 目录时应该使用相对路径,否则使用绝对路径(开发模式),而插件更新不存在这样的问题,因此只需要解决安装应该是遗漏了
Additional information
/kind improvement
/area core
/milestone 2.7.x
/assign -
guqing created a review on pull request #21 in halo-sigs/plugin-bytemd
-
guqing pushed to refs/heads/main in guqing/halo-theme-higan