• @guqing guqing commented on pull request #26 in halo-dev/plugin-sitemap

    如果这是为了防止“恶意访问”，30s 缓存时间应该足够了。

    好

    0 0
  • @guqing guqing pushed to refactor/last-mod in guqing/plugin-sitemap

    Below is the list of commits:

    0 0
  • @guqing guqing created a review on pull request #56 in halo-sigs/richtext-editor

    /lgtm

    image

    0 0
  • @guqing guqing commented on pull request #26 in halo-dev/plugin-sitemap

    既然已知 Google 会一天后才会重新抓取，那这里用缓存的意义就不是很大了。

    怕被恶意访问, 每次生成都是查询全部文章和页面分类等消耗很大

    0 0
  • @guqing guqing created a review on pull request #4662 in halo-dev/halo

    /lgtm

    0 0
  • @guqing guqing commented on issue #26 in halo-dev/plugin-sitemap

    BUILD FAILED in 9s
    8 actionable tasks: 6 executed, 2 up-to-date

    已修复单元测试 00972b2

    0 0
  • @guqing guqing pushed to refactor/last-mod in guqing/plugin-sitemap

    Below is the list of commits:

    0 0
  • @guqing guqing commented on pull request #26 in halo-dev/plugin-sitemap

    不太明白这里为什么需要将缓存设置为 1 天。更新文章后甚至还需要重启插件才能生效。

    因为 sitemap 的更新频率设置为了 daliy, google 最少需要一天才会重新抓取, 生成后会将 sitemap 缓存下来而不是每次访问都去查询数据来生成,这里的过期时间 ofSeconds 应该是用错方法了之前一直以为是半小时,重启插件缓存就没了所以可以实时看到结果,但sitemap并不要求实时性,描述说重启是为了看日期设置的是否正确而已

    0 0
  • @guqing guqing commented on issue #4663 in halo-dev/halo

    /hold wait for #4589 is merged, perhaps there is a conflict that needs to be resolved

    0 0
  • @guqing guqing opened pull request #4663 in halo-dev/halo

    What type of PR is this?

    /kind improvement
    /area core
    /area plugin
    /milestone 2.10.0

    What this PR does / why we need it:

    重构插件类加载器以优化当插件的 resources 目录资源与 Halo 中同名时加载不到的问题

    how to test it?

    1. 在创建的 resources/extensions 目录创建一个与 halo 的 resources/extensions 目录中已存在的同名 yaml
    2. 使用插件观察插件的同名文件 yaml 是否被 apply 到 halo 中
    3. 测试插件的其他功能是否正常比如静态资源加载如 logo 等

    Which issue(s) this PR fixes:

    Fixes #4610

    Does this PR introduce a user-facing change?

    重构插件类加载器以优化当插件的 resources 目录资源与 Halo 中同名时加载不到的问题
    0 0