• see halo-sigs/plugin-migrate#24
    需要在 https://github.com/halo-sigs/plugin-s3/blob/23208009073fae1c76eacee58b0d89e54bbbce29/src/main/java/run/halo/s3os/S3OsAttachmentHandler.java#L145C28-L145C28 方法做一下兼容处理以解决旧数据问题,当获取不到 Object Key 时获取 storage.halo.run/external-link 作为 permalink 当获取不到时再抛异常,这样修改后需要注意检查删除功能是否正常

    0 0
  • 异常信息:

    java.lang.IllegalArgumentException: Cannot obtain object key from attachment attachment-syikU
            at run.halo.s3os.S3OsAttachmentHandler.getPermalink(S3OsAttachmentHandler.java:147) ~[na:na]
            at run.halo.app.core.extension.service.impl.DefaultAttachmentService.lambda$getPermalink$11(DefaultAttachmentService.java:107) ~[classes/:2.8.0]
            at reactor.core.publisher.FluxConcatMapNoPrefetch$FluxConcatMapNoPrefetchSubscriber.onNext(FluxConcatMapNoPrefetch.java:183) ~[reactor-core-3.5.8.jar:3.5.8]
            at reactor.core.publisher.FluxIterable$IterableSubscription.slowPath(FluxIterable.java:335) ~[reactor-core-3.5.8.jar:3.5.8]
            at reactor.core.publisher.FluxIterable$IterableSubscription.request(FluxIterable.java:294) ~[reactor-core-3.5.8.jar:3.5.8]
    
    Attachment Data Example
    {
        "spec": {
            "displayName": "wallhaven-4dgrym",
            "groupName": "attachment-group-illustration",
            "policyName": "policy-aliyun-illustration",
            "ownerName": "guqing",
            "mediaType": "image/jpeg",
            "size": 227739
        },
        "status": {
            "permalink": "https://guqing-blog.oss-cn-hangzhou.aliyuncs.com/wallhaven-4dgrym_1590148556987.jpg?x-oss-process=style/common_style"
        },
        "apiVersion": "storage.halo.run/v1alpha1",
        "kind": "Attachment",
        "metadata": {
            "generateName": "attachment-",
            "finalizers": [
                "attachment-manager"
            ],
            "name": "attachment-syikU",
            "annotations": {
                "storage.halo.run/height": "2500",
                "storage.halo.run/suffix": "jpg",
                "storage.halo.run/width": "4000",
                "storage.halo.run/external-link": "https://guqing-blog.oss-cn-hangzhou.aliyuncs.com/wallhaven-4dgrym_1590148556987.jpg?x-oss-process=style/common_style"
            },
            "version": 2,
            "creationTimestamp": "2023-02-15T10:17:56.328009475Z"
        }
    }
    
    0 0
  • @guqing guqing created a review on pull request #237 in halo-dev/docs

    /lgtm

    0 0
  • 异常信息:

    java.lang.IllegalArgumentException: Cannot obtain object key from attachment attachment-syikU
            at run.halo.s3os.S3OsAttachmentHandler.getPermalink(S3OsAttachmentHandler.java:147) ~[na:na]
            at run.halo.app.core.extension.service.impl.DefaultAttachmentService.lambda$getPermalink$11(DefaultAttachmentService.java:107) ~[classes/:2.8.0]
            at reactor.core.publisher.FluxConcatMapNoPrefetch$FluxConcatMapNoPrefetchSubscriber.onNext(FluxConcatMapNoPrefetch.java:183) ~[reactor-core-3.5.8.jar:3.5.8]
            at reactor.core.publisher.FluxIterable$IterableSubscription.slowPath(FluxIterable.java:335) ~[reactor-core-3.5.8.jar:3.5.8]
            at reactor.core.publisher.FluxIterable$IterableSubscription.request(FluxIterable.java:294) ~[reactor-core-3.5.8.jar:3.5.8]
    Attachment Data Example
    {
        "spec": {
            "displayName": "wallhaven-4dgrym",
            "groupName": "attachment-group-illustration",
            "policyName": "policy-aliyun-illustration",
            "ownerName": "guqing",
            "mediaType": "image/jpeg",
            "size": 227739
        },
        "status": {
            "permalink": "https://guqing-blog.oss-cn-hangzhou.aliyuncs.com/wallhaven-4dgrym_1590148556987.jpg?x-oss-process=style/common_style"
        },
        "apiVersion": "storage.halo.run/v1alpha1",
        "kind": "Attachment",
        "metadata": {
            "generateName": "attachment-",
            "finalizers": [
                "attachment-manager"
            ],
            "name": "attachment-syikU",
            "annotations": {
                "storage.halo.run/height": "2500",
                "storage.halo.run/suffix": "jpg",
                "storage.halo.run/width": "4000",
                "storage.halo.run/external-link": "https://guqing-blog.oss-cn-hangzhou.aliyuncs.com/wallhaven-4dgrym_1590148556987.jpg?x-oss-process=style/common_style"
            },
            "version": 2,
            "creationTimestamp": "2023-02-15T10:17:56.328009475Z"
        }
    }
    0 0
  • @guqing guqing created a review on pull request #49 in halo-sigs/awesome-halo

    /approve

    0 0
  • @guqing guqing created a review on pull request #4334 in halo-dev/halo

    /lgtm

    0 0
  • @guqing guqing commented on pull request #49 in halo-sigs/awesome-halo
    - [plugin-bilibili-bangumi](https://github.com/Roozenlz/plugin-bilibili-bangumi) - Halo 2.0 的追番插件,可以为主题提供追番数据及 `/bangumis` 页面路由
    
    0 0
  • @guqing guqing created a review on pull request #4341 in halo-dev/halo

    /lgtm

    0 0
  • 0 0
  • @guqing guqing created a review on pull request #28 in halo-sigs/plugin-bytemd

    /lgtm
    👍

    0 0