瞬间

guqing commented on issue #40 in halo-dev/plugin-app-store

guqing commented on pull request #39 in halo-dev/plugin-app-store

  return semver.satisfies(version, requires, { includePrerelease: true });

version 不存在只有可能在开发模式的情况下出现,当不存在时已经赋值为 0.0.0 所以直接走 semver.satisfies 即可,而当生产模式的时候不会存在 version 不存在的情况所以将 version === "0.0.0" 去掉可以在每次检查时简化一次判断

0 0

guqing commented on issue #4663 in halo-dev/halo

/unhold

0 0

guqing pushed to refactor/4610 in guqing/halo

Below is the list of commits:

refactor: plugin resource loading to only load from plugin itself instead of delegating to core (f7ccb65)

0 0

guqing pushed to refactor/4610 in guqing/halo

Below is the list of commits:

refactor: user detail page structure (#4664) (470b0de)
feat: support running plugins from JAR in development mode (#4589) (1f0cfc1)
feat: add configration route for auth provider item (#4635) (9b310ca)
Merge remote-tracking branch 'upstream/main' into refactor/4610 (c56a07d)

0 0

guqing commented on issue #4639 in halo-dev/halo

这里用 etag 能否解决问题呢？如果可以的话，可能就不需要缓存 js 和 css 到本地磁盘。

这里的问题与 http 缓存没有关系，主要是慢在每次访问bundle的时候需要去所有插件里面读取文件然后合并而去所有插件里面读取main.js和style.css的这个过程可以简化，作出的优化就是只合并一次写入到一个文件下次访问就只读取一个文件减少了IO次数，如果插件有变化那就再去重新读取并合并更新到文件以此类推

0 0

guqing created a review on pull request #4664 in halo-dev/halo

/lgtm

0 0

guqing commented on pull request #39 in halo-dev/plugin-app-store

可以对这个方法添加单元测试吗

0 0

guqing created a review on pull request #37 in halo-dev/plugin-app-store

/lgtm

0 0

guqing commented on issue #38 in halo-dev/plugin-app-store

统一一下就好了，如果需要支持固定的版本号，比如必须在 2.6.0 版本才能使用其他的都不行，那么就需要 halo 支持一下固定版本号

0 0